Fix additional bug in ECAdd #1666
Merged
+104
−191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…se to another bug found/fixed in my original writeup.
mpharrigan
reviewed
Jul 7, 2025
|
sorry, I missed that the fix was pushed. Please feel free to comment on PRs when you're ready for re-review so I get a notification! |
mpharrigan
approved these changes
Aug 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Team from PsiQuantum reached out and pointed out another bug in the circuit nearly equivalent to one of the other ones that I found/fixed.
When [(a, b) = (0, 0) AND x = 0] OR [(x, y) = (0, 0) AND a = 0], the f_1 flag is not cleared. I added the same fix to this situation that I did in the similar scenario when the b/y values are all 0 for the f_2 flag. This cost 2 3n-controlled toffolis.